Patch Set 1: Looks good to me, but someone else must approve

Uploaded patch set 2.

Patch Set 2: Code-Review+1

Patch Set 3: Patch Set 2 was rebased

Patch Set 3: Code-Review+1

Patch Set 4: Patch Set 3 was rebased

Patch Set 5: Patch Set 4 was rebased

Patch Set 5: Code-Review+1

Patch Set 5: Code-Review-1

I don't really understand the use case for this.

What happens for users who are mirroring a manifest that has path attributes, but they want the mirror to be created in the path according to the Git's name? This change will break repo for them.

Patch Set 5:

David Pursehouse, i had forwarded an email to you with two attached files to make clear why i change it from 'name' to 'path', i means, we can place the git project in a special path. Indeed, if the git path attr not exist in the manifest file, its value will be the same as the git name attr.

Patch Set 5:

This will break repo for people who use the --mirror option and expect the directories to be named according to the name of the git (even if the path attribute is specified).

If this functionality is needed, I would prefer it to be enabled by a command line option. The default behaviour should be as it is now, and only changed if the user explicitly passes the command line option.

Uploaded patch set 6.

Patch Set 6: Code-Review+1

David Pursehouse, I agree with you. To simple this change, i just use additional 'force-path' attr for each project as the enable option.

Patch Set 6: Code-Review-1

(1 comment)

I would prefer to have this as a command line option, so that existing manifests do not need to be edited.

Or, if others disagree and the manifest attribute is acceptable, then it should be documented in docs/manifest-format.txt

Uploaded patch set 7.